AutoMapping: Optimized reloading of rule maps #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only deleting the AutoMapper instances for changed rule map files, the reloading becomes much faster since it can just reuse the still loaded instances.
bjorn
force-pushed
the
automapping-optimize-rule-reload
branch
from
a593a2a to
7f6bf7f
Compare
This optimizes AutoMapping operations by not loading rule maps which do not apply to the current map based on file name filters. Also, re-parsing of the rules.txt file(s) now only happens when any of such files were changed, not when rule maps have changed.
bjorn
force-pushed
the
automapping-optimize-rule-reload
branch
from
7f6bf7f to
339b504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By only deleting the
AutoMapperinstances for changed rule map files, the reloading becomes much faster since it can just reuse the still loaded instances.Additionally, on-demand loading of rule maps avoids loading rule maps which do not apply to the current map based on file name filters.
Finally, re-parsing of the
rules.txtfile(s) now only happens when any of such files were changed, not when rule maps have changed.